From: Paul Donald Date: Wed, 23 Apr 2025 12:03:39 +0000 (+0200) Subject: luci-mod-network: widgets shall show devices that are online as online X-Git-Url: http://git.openwrt.org/%22https:/collectd.org/%22http:/www.crowdsec.net//%22https%22/%22https:/collectd.org/%22http:/www.crowdsec.net/%22https%22?a=commitdiff_plain;h=a288354e78d4dd5872dea52bcebf7d1f91fad3b1;p=project%2Fluci.git luci-mod-network: widgets shall show devices that are online as online Tunnel devices which are up, show as down, since the config being enumerated does not have access to any device status. The 'device' being enumerated is e.g. 'wireguard_wg0', a configuration for a tunnel interface, whose parent is an 'ethernet' type. That's a bug for another day. So they shall use parent device status. Signed-off-by: Paul Donald --- diff --git a/modules/luci-mod-network/htdocs/luci-static/resources/view/network/interfaces.js b/modules/luci-mod-network/htdocs/luci-static/resources/view/network/interfaces.js index 9074d9b9fa..702fb3fde2 100644 --- a/modules/luci-mod-network/htdocs/luci-static/resources/view/network/interfaces.js +++ b/modules/luci-mod-network/htdocs/luci-static/resources/view/network/interfaces.js @@ -103,7 +103,7 @@ function render_modal_status(node, ifc) { dom.content(node, [ E('img', { - 'src': L.resource('icons/%s%s.png').format(dev ? dev.getType() : 'ethernet', (dev && dev.isUp()) ? '' : '_disabled'), + 'src': L.resource('icons/%s%s.png').format(dev ? dev.getType() : 'ethernet', ifc.isUp() ? '' : '_disabled'), 'title': dev ? dev.getTypeI18n() : _('Not present') }), ifc ? render_status(E('span'), ifc, true) : E('em', _('Interface not present or not connected yet.')) @@ -297,7 +297,7 @@ return view.extend({ var dev = ifc.getDevice(); dom.content(stat, [ E('img', { - 'src': L.resource('icons/%s%s.png').format(dev ? dev.getType() : 'ethernet', (dev && dev.isUp()) ? '' : '_disabled'), + 'src': L.resource('icons/%s%s.png').format(dev ? dev.getType() : 'ethernet', ifc.isUp() ? '' : '_disabled'), 'title': dev ? dev.getTypeI18n() : _('Not present') }), render_status(E('span'), ifc, true)